Only use v14 decoding for events #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For events, the Python is the same speed at decoding as bt-decode (sometimes faster). However, the Python scalecodec offers significantly better decoding, and doesn't rely on us hacking it after the fact.
Compare the following.
bt-decode
scalecodec:
The bt-decode version does not decode the SS58s. In addition, we'd previously had to use various hacks to get inner values to parse correctly:
async-substrate-interface/async_substrate_interface/async_substrate.py
Lines 1933 to 1939 in 35728ab
which changes
{"pays_fee": {"Yes": ()}}
to{"pays_fee": "Yes"}
This rectifies these issues by just using the MetadataV14 decoder.