fix: IP range validation and improved error handling #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewhaleking
requested changes
May 5, 2025
Comment on lines
+12
to
+13
| :raises: netaddr.core.AddrFormatError: Raised when the passed int_val is | ||
| not a valid IP integer value. |
There was a problem hiding this comment.
This is not the exception raised. You have changed this to a ValueError.
Comment on lines
+17
to
+18
| except netaddr.core.AddrFormatError as e: | ||
| raise ValueError(f"Invalid IP integer value: {int_val}") from e |
There was a problem hiding this comment.
Please do not change exception raises like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have corrected the ranges for both IPv4 and IPv6 to ensure they align with valid address formats.
Additionally, I’ve added a try-except block to better handle exceptions related to incorrect IP values. If an invalid IP is encountered, the error message is now more informative and easier to understand.