-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add image-upload e2e-test #50
Conversation
WalkthroughThe changes introduce a new test file, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
packages/docs/fluent-editor/demos/image-upload.spec.ts (1)
1-8
: Review imports and constants setup.The imports and constants are appropriately set up for handling file paths in a node environment. However, the comment on line 4 might be misleading or unnecessary. Consider removing or clarifying this comment to avoid confusion.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
test/unit/components/__snapshots__/Button.spec.ts.snap
is excluded by!**/*.snap
Files selected for processing (1)
- packages/docs/fluent-editor/demos/image-upload.spec.ts (1 hunks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/docs/fluent-editor/demos/image-upload.spec.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/docs/fluent-editor/demos/image-upload.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/docs/fluent-editor/demos/image-upload.spec.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/docs/fluent-editor/demos/image-upload.spec.ts
@Janson1012 我看格式有点点问题,可以安装一个 VSCode 插件: |
好的 |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit