Empirical delay

[t2gran]

Summary

Decorate Trip calls with empirical delay information

Issue

Closes #6874

Unit tests

✅ All business logic and most framework code have good unit test coverage.

Documentation

• Transmodel API doc added
• Sandbox doc added
• Config doc added
• Java doc added

Changelog

🟥 This is a sandbox PR

Bumping the serialization version id

✅ The empirical delay is part of the serialized graph.

[codecov]

Codecov Report

❌ Patch coverage is 81.54897% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.20%. Comparing base (87cf700) to head (f838d9e).
⚠️ Report is 62 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...ernal/graphbuilder/EmpiricalDelayGraphBuilder.java	29.03%	22 Missing ⚠️
...transmodel/model/timetable/EmpiricalDelayType.java	61.29%	12 Missing ⚠️
...internal/csvinput/EmpiricalDelayCsvDataReader.java	80.00%	8 Missing and 3 partials ⚠️
...planner/graph_builder/GraphBuilderDataSources.java	0.00%	8 Missing ⚠️
...ay/configure/EmpiricalDelayGraphBuilderModule.java	0.00%	5 Missing ⚠️
...aldelay/configure/EmpiricalDelayServiceModule.java	0.00%	4 Missing ⚠️
...anner/ext/empiricaldelay/model/EmpiricalDelay.java	75.00%	1 Missing and 2 partials ⚠️
...rg/opentripplanner/graph_builder/GraphBuilder.java	0.00%	3 Missing ⚠️
...ner/standalone/configure/ConstructApplication.java	0.00%	3 Missing ⚠️
...elay/configure/EmpiricalDelayRepositoryModule.java	0.00%	2 Missing ⚠️
... and 6 more

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6875      +/-   ##
=============================================
+ Coverage      72.14%   72.20%   +0.06%     
- Complexity     19673    19809     +136     
=============================================
  Files           2127     2151      +24     
  Lines          79562    79997     +435     
  Branches        8041     8072      +31     
=============================================
+ Hits           57397    57760     +363     
- Misses         19331    19400      +69     
- Partials        2834     2837       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[optionsome]

This is probably a good candidate for a discussion on if this information is something we should have in OTP or not. I'm leaning towards that it would be ok to have this in OTP as some client might want to show this information, but this feels like a mostly like a statistic that isn't meant for passengers.

[miklcct]

I don't think it should be in OTP yet until there is an international standard to specify these information. It is the authority's responsibility to make a timetable which is reliable.

[leonardehrenfried]

You appear to have made a change in the debug UI code - probably by accident. That's why the frontend linter fails.

[t2gran]

You appear to have made a change in the debug UI code - probably by accident. That's why the frontend linter fails.

For some reason I can understand IntelliJ keep skipping whitespace changes when commiting as part of merging in dev-2.x. I have done this several times - same result. Finally I commited with git on the comand-line and the problem is gone.