Add StreetDetailsService for storing level and incline information for edges
#6897
+1,633
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DecoratorRepository.
…into stairs-escalators-elevators-gtfs-graphql
optionsome
reviewed
Oct 27, 2025
...tripplanner/model/plan/walkstep/verticaltransportation/VerticalTransportationUseFactory.java
Outdated
Show resolved
Hide resolved
...tripplanner/model/plan/walkstep/verticaltransportation/VerticalTransportationUseFactory.java
Outdated
Show resolved
Hide resolved
...tripplanner/model/plan/walkstep/verticaltransportation/VerticalTransportationUseFactory.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/apis/gtfs/datafetchers/stepImpl.java
Outdated
Show resolved
Hide resolved
optionsome
reviewed
Oct 27, 2025
application/src/main/java/org/opentripplanner/service/streetdetails/model/Level.java
Outdated
Show resolved
Hide resolved
VillePihlava
changed the title
OsmStreetDecoratorService for storing level and incline information for edgesStreetDetailsService for storing level and incline information for edges
optionsome
reviewed
Oct 28, 2025
Member
optionsome
left a comment
optionsome
left a comment
There was a problem hiding this comment.
Could you try adding GraphQL integration tests for the new features?
Contributor
Author
done |
application/src/main/java/org/opentripplanner/apis/gtfs/datafetchers/stepImpl.java
Outdated
Show resolved
Hide resolved
...a/org/opentripplanner/graph_builder/module/osm/edgelevelinfo/NoopEdgeLevelInfoProcessor.java
Outdated
Show resolved
Hide resolved
application/src/main/resources/org/opentripplanner/apis/gtfs/schema.graphqls
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/apis/gtfs/datafetchers/stepImpl.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
requested changes
Nov 5, 2025
Member
leonardehrenfried
left a comment
leonardehrenfried
left a comment
There was a problem hiding this comment.
I probably missed something, but I would like to know why half the features are created in the WalkStepMapper and the other half isn't.
Let's discuss in the dev meeting.
…into stairs-escalators-elevators-gtfs-graphql
optionsome
reviewed
Nov 7, 2025
| if (verticalTransportationUse instanceof EscalatorUse escalatorUse) { | ||
| return escalatorUse; | ||
| } else if (verticalTransportationUse instanceof StairsUse stairsUse) { | ||
| return stairsUse; |
Member
There was a problem hiding this comment.
You could still use the switch here. On the other hand, are these ifs even necessary, could you just return verticalTransportationUse? The StepFeatureTypeResolver should handle the supported types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
StreetDetailsServicewhich is used for storing level and incline information for edges. A build config field is provided to enable/disable storing level and incline info. This PR also adds info about stairs, escalators, and elevators to the walksteps of a leg of the GTFS GraphQL API.I also did some refactoring where I felt it was necessary, e.g. in
EscalatorProcessorandOsmModule.Issue
Closes #6829
Unit tests
New tests:
Documentation