Skip to content

Conversation

@testower
Copy link
Contributor

@testower testower commented Sep 25, 2025

Summary

THIS IS A BREAKING CHANGE.

Changes the vehiclerentalservicedirectory sandbox to use the manifest.json file from GBFS v3 as a way to discover available GBFS feeds. The manifest.json file can either be fetched from a remote server or served as a file on the local file system.

If multiple GBFS versions are available for a specific feed / system, we will choose the latest available (and supported) version.

Issue

Continuation of #6735 and related to #6708

Unit tests

This sandbox doesn't have tests. Tested manually.

Documentation

The documentation was updated.

Changelog

Do we use changelogs for sandbox code?

@testower testower added +Sandbox This will be implemented as a Sandbox feature +Config Change This PR might require the configuration to be updated. labels Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 11.11111% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.09%. Comparing base (cc6c6c6) to head (8ea3513).
⚠️ Report is 280 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...irectory/VehicleRentalServiceDirectoryFetcher.java 0.00% 48 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6900      +/-   ##
=============================================
- Coverage      72.10%   72.09%   -0.02%     
  Complexity     19660    19660              
=============================================
  Files           2124     2124              
  Lines          79507    79503       -4     
  Branches        8050     8050              
=============================================
- Hits           57326    57314      -12     
- Misses         19344    19353       +9     
+ Partials        2837     2836       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@testower testower added Entur Test This is currently being tested at Entur and removed Entur Test This is currently being tested at Entur labels Sep 30, 2025
@vpaturet vpaturet added Entur Test This is currently being tested at Entur and removed Entur Test This is currently being tested at Entur labels Oct 1, 2025
@testower testower marked this pull request as ready for review October 1, 2025 18:52
@testower testower requested a review from a team as a code owner October 1, 2025 18:52
@testower testower added the +Skip Changelog This is not a relevant change for a product owner since last release. label Oct 1, 2025
@testower testower self-assigned this Oct 6, 2025
@testower testower marked this pull request as draft October 7, 2025 09:26
@testower testower marked this pull request as ready for review October 13, 2025 10:51
@leonardehrenfried leonardehrenfried changed the title Feature/gbfs 3 0 service discovery Use GBFS 3 manifest for feed discovery in rental service directory Oct 14, 2025
Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This satisfies the sandbox contract and I cannot see anything malicious in it.

@hbruch, the only other known user of this sandbox feature, has said he is fine with this change.

@vpaturet
Copy link
Contributor

I would not skip the changelog for this PR

@testower testower removed the +Skip Changelog This is not a relevant change for a product owner since last release. label Oct 16, 2025
@testower testower merged commit 0ff51e7 into opentripplanner:dev-2.x Oct 16, 2025
10 checks passed
@testower testower deleted the feature/gbfs-3-0-service-discovery branch October 16, 2025 18:42
@testower testower removed the Entur Test This is currently being tested at Entur label Oct 16, 2025
t2gran pushed a commit that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Config Change This PR might require the configuration to be updated. +Sandbox This will be implemented as a Sandbox feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants