-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use GBFS 3 manifest for feed discovery in rental service directory #6900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GBFS 3 manifest for feed discovery in rental service directory #6900
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6900 +/- ##
=============================================
- Coverage 72.10% 72.09% -0.02%
Complexity 19660 19660
=============================================
Files 2124 2124
Lines 79507 79503 -4
Branches 8050 8050
=============================================
- Hits 57326 57314 -12
- Misses 19344 19353 +9
+ Partials 2837 2836 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonardehrenfried
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This satisfies the sandbox contract and I cannot see anything malicious in it.
@hbruch, the only other known user of this sandbox feature, has said he is fine with this change.
|
I would not skip the changelog for this PR |
Summary
THIS IS A BREAKING CHANGE.
Changes the
vehiclerentalservicedirectorysandbox to use the manifest.json file from GBFS v3 as a way to discover available GBFS feeds. The manifest.json file can either be fetched from a remote server or served as a file on the local file system.If multiple GBFS versions are available for a specific feed / system, we will choose the latest available (and supported) version.
Issue
Continuation of #6735 and related to #6708
Unit tests
This sandbox doesn't have tests. Tested manually.
Documentation
The documentation was updated.
Changelog
Do we use changelogs for sandbox code?