Include route.shortname in the transitive route label #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
requested changes
Sep 8, 2025
lib/app.js
Outdated
| @@ -167,7 +167,7 @@ const components = { | |||
| * @returns A string with the custom label to display for the given leg, or null to render no label. | |||
| */ | |||
| getTransitiveRouteLabel: (itineraryLeg) => { | |||
| return itineraryLeg.routeShortName // null or undefined or empty string will tell transitive-js to not render a route label. | |||
| return itineraryLeg.routeShortName || itineraryLeg.route.shortName // null or undefined or empty string will tell transitive-js to not render a route label. | |||
There was a problem hiding this comment.
Do we know route will exist? Will it always have a shortname?
There was a problem hiding this comment.
I added a conditional to route. If there's no short name, it'll return undefined which in theory transitive should handle gracefully ( it doesn't but that's out of the scope of this PR)
There was a problem hiding this comment.
What if the route object is missing?
There was a problem hiding this comment.
Then it'll return undefined.
miles-grant-ibigroup
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make sure all available short names are passed to transitive overlay.
A follow up OTP-UI PR is needed because the comment on this line (that a blank string will render no label) is not the case with the new transitive overlay bubbles.
PR Checklist: