Force geolocate control to update UI #1490
Open
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
assigned
miles-grant-ibigroup and
alec-georgoff and unassigned
miles-grant-ibigroup
alec-georgoff
approved these changes
Oct 31, 2025
miles-grant-ibigroup
requested changes
Nov 6, 2025
| const viewedRoute = state.otp?.ui?.viewedRoute?.routeId | ||
| const activeNearbyFilters = state.otp?.ui?.nearbyView?.filters | ||
| const nearbyFilters = state.otp.config?.nearbyView?.filters | ||
| const stops = state.otp.transitIndex.stops |
There was a problem hiding this comment.
No more stops?
| mapLibreProps={{ reuseMaps: true }} | ||
| mapLibreProps={{ | ||
| onLoad: () => { | ||
| return this.setState({ mapLoad: true }) |
There was a problem hiding this comment.
Would it be possible to add a comment here that this is about the hack above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where even if a user's location was clearly blocked on mobile, the geolocate button would not reflect that. Now if the app has an existing location error, we will subtly trigger the geolocate button so it updates its UI.
PR Checklist: