Fix Route Renderer Data #1508
Merged
Fix Route Renderer Data #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
changed the title
binh-dam-ibigroup
changed the title
daniel-heppner-ibigroup
approved these changes
Dec 31, 2025
Contributor
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
Big improvement! thanks!
daniel-heppner-ibigroup
assigned
binh-dam-ibigroup and unassigned
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes legacy OTP1 fields from the data passed to
RouteRendererto address compatibility with custom route renderers that use OTP2-only objects. This is possible because we are already querying theagencyobject with id and name when we query the entire list of routes for the route viewer.Tested with ST and ATL configs.
PR Checklist: