Fix logic in handling of an empty private points list in gvar#856
Draft
wiltse439 wants to merge 14 commits into
Draft
Fix logic in handling of an empty private points list in gvar#856wiltse439 wants to merge 14 commits into
wiltse439 wants to merge 14 commits into
Conversation
…API endpoint for variation axis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in handling gvar tuples when the private points count is set to zero.
Description
If a font defined shared points in gvar, but one of the glyphs sets the private-points flag, but has a private points length of zero, then the specification says that all points should be used. The code previously had some logic to handle this case, but it was not quite correct and we would end up using completely random values.
Motivation and Context
In the version of the Roboto font in the GitHub free fonts project, the period is defined with this value. When the weight axis exceeds 400, the logic bug would cause a dramatic distortion in the path.
How Has This Been Tested?
Using the mentioned Roboto variable font and setting the weight > 400, with a "." as text in the font inspector.
Screenshots (if appropriate):
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).