Skip to content

Aanuf/sdpa v fp8#3485

Merged
alexsu52 merged 34 commits into
openvinotoolkit:developfrom
andreyanufr:aanuf/SDPA_V_fp8
May 30, 2025
Merged

Aanuf/sdpa v fp8#3485
alexsu52 merged 34 commits into
openvinotoolkit:developfrom
andreyanufr:aanuf/SDPA_V_fp8

Conversation

@andreyanufr

@andreyanufr andreyanufr commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Changes

FakeConverr for V tensor for SDPA layer in the case of FP8 quantization for NPU performance.

Reason for changes

Related tickets

CVS-166427

Tests

In process.

@github-actions github-actions Bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ labels May 8, 2025
@andreyanufr andreyanufr marked this pull request as ready for review May 8, 2025 14:01
@andreyanufr andreyanufr requested a review from a team as a code owner May 8, 2025 14:01
Comment thread nncf/common/quantization/quantizer_propagation/solver.py Outdated

@alexsu52 alexsu52 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed offline, please add support for attention subgraph without sdpa via disabling ignored patterns. cc' @xiao1228

@andreyanufr andreyanufr requested review from alexsu52 and nikita-malininn and removed request for nikita-malininn May 21, 2025 13:18
Comment thread nncf/common/graph/operator_metatypes.py Outdated
Comment thread nncf/common/graph/operator_metatypes.py Outdated
@github-actions github-actions Bot removed the NNCF PT Pull requests that updates NNCF PyTorch label May 28, 2025

@alexsu52 alexsu52 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address my minor comment.

else:
qconf_list = [deepcopy(DEFAULT_QUANTIZER_CONFIG)]

op_override_params = {}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about introducing the separate function?

@alexsu52 alexsu52 merged commit 4db8300 into openvinotoolkit:develop May 30, 2025
19 checks passed
andreyanufr added a commit to AlexanderDokuchaev/nncf that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Freeze NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants