Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and fixes #54

Merged
merged 3 commits into from
Mar 15, 2025
Merged

chore: cleanup and fixes #54

merged 3 commits into from
Mar 15, 2025

Conversation

TimoGlastra
Copy link
Contributor

Fixes #34
Fixes #48

It also does some general cleanup, and removes the getOpenId4vp request payload callback. It seems that every request should have an unique url and thus the request can be linked to the response before this library is invoked (we don't have to look at the header). This might change based on outcome of openid/OpenID4VP#441

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Copy link

changeset-bot bot commented Mar 15, 2025

⚠️ No Changeset found

Latest commit: 72e6eac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra
Copy link
Contributor Author

Not adding changesets as it's all for pre-released functionality

@TimoGlastra TimoGlastra requested a review from auer-martin March 15, 2025 15:23
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
Copy link
Contributor Author

@auer-martin want to wrap up the integration in Credo so merging. Feel free to leave any comments still, I'll address them in a follow up PR before we make a stable release

@TimoGlastra TimoGlastra merged commit 3caf831 into main Mar 15, 2025
5 checks passed
@TimoGlastra TimoGlastra deleted the chore/cleanup-and-fixes branch March 15, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not require kid in JARM response encrypted JWT Rename authRequestPayload and authResponsePayload
1 participant