Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor UI issues for OpenID cards #1465

Conversation

MosCD3
Copy link
Contributor

@MosCD3 MosCD3 commented Mar 14, 2025

Summary of Changes

  1. Reformat extra attribute to include attribute name/value
  2. Disable multiple credentials support for PresentationProof for OpenID

Screenshots, videos, or gifs

IMG_04273499DF56-1

Breaking change guide

Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

Signed-off-by: Mostafa Gamal <[email protected]>
@MosCD3 MosCD3 marked this pull request as ready for review March 14, 2025 20:11
@MosCD3 MosCD3 requested a review from a team as a code owner March 14, 2025 20:11
@MosCD3 MosCD3 changed the title refactor: fix UI issues for OpenID cards refactor: refactor UI issues for OpenID cards Mar 14, 2025
@MosCD3 MosCD3 requested a review from bryce-mcmath March 17, 2025 14:08
@MosCD3 MosCD3 requested a review from fc-santos March 17, 2025 14:30
@bryce-mcmath bryce-mcmath merged commit dd05ef5 into openwallet-foundation:main Mar 17, 2025
8 checks passed
@bryce-mcmath bryce-mcmath deleted the sandbox/moscd3/some-openid-fixes branch March 17, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants