Fix some issues with sample problem documentation generation. (hotfix of #1312) #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I updated the sample problem documentation to use CodeMirror 6, apparently prettier accidentally ran on the `problem-template.mt` file (due to the format on save feature in my editor). Since that is a Mojolicious template file, prettier does not do the right thing, and messed that file up pretty well. So this fixes the resulting issues. Also, fix several typos in the sample problems that have a PODLINK or PROBLINK that have incorrect macro or sample problem file names. These cause "use of unitialized value" warnings when the `parse-problem-doc.pl` script is executed. These warnings also occur when loading these sample problems via webwork2. Finally, switch the sample problem templates to using the same version of Bootstrap that webwork2 uses.
drgrice1
force-pushed
the
sample-problem-generation-issues-hotfix
branch
from
3705011 to
9232eb2
Compare
pstaabp
approved these changes
Sep 9, 2025
Alex-Jordan
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I updated the sample problem documentation to use CodeMirror 6, apparently prettier accidentally ran on the
problem-template.mtfile (due to the format on save feature in my editor). Since that is a Mojolicious template file, prettier does not do the right thing, and messed that file up pretty well. So this fixes the resulting issues.Also, fix several typos in the sample problems that have a PODLINK or PROBLINK that have incorrect macro or sample problem file names. These cause "use of unitialized value" warnings when the
parse-problem-doc.plscript is executed. These warnings also occur when loading these sample problems via webwork2.Finally, switch the sample problem templates to using the same version of Bootstrap that webwork2 uses.
This hotfix is needed so that we can update the sample problems and macros for PG 2.20 at https://openwebwork.github.io/pg-docs.