[deps] Add Django 5.x & Python 3.11-3.13 support, drop Django 3.2/Python 3.8 #38

Eeshu-Yadav · 2025-04-02T14:30:32Z

Description

Adds support for:
- Django 5.0 & 5.1
- Python 3.11, 3.12 & 3.13
Drops support for:
- Django 3.2
- Python 3.8

Checklist

Updated setup.py version constraints
Added new Python/Django versions to CI

Fixes #35

pandafy · 2025-04-02T15:06:12Z

setup.py

-    install_requires=[],
+    python_requires='>=3.9',
+    install_requires=[
+        'django>=4.2,<=5.1',


Suggested change

'django>=4.2,<=5.1',

'django>=4.2,<5.3',

pandafy

@Eeshu-Yadav the build is failing for QA checks

codesankalp · 2025-04-02T18:31:19Z

.github/workflows/ci.yml

+    - name: Cache APT packages
+      uses: actions/cache@v4
+      with:
+        path: /var/cache/apt/archives
+        key: apt-${{ runner.os }}-${{ hashFiles('.github/workflows/ci.yml') }}
+        restore-keys: |
+          apt-${{ runner.os }}-
+
+    - name: Disable man page auto-update
+      run: |
+        echo 'set man-db/auto-update false' | sudo debconf-communicate >/dev/null
+        sudo dpkg-reconfigure man-db


Why do we need this change?

@codesankalp we're adding this to all the repos to speed up builds

Added: - Support for Django >=5.1,<5.3 - Support for Python 3.12, 3.14 Removed: - Support for Python < 3.9 - Support for Django < 4.2 Closes openwisp#38

Eeshu-Yadav · 2025-04-02T21:38:50Z

@pandafy now the build is not failing , now it can be merged ?

nemesifier · 2025-04-02T21:43:09Z

.github/workflows/ci.yml

-
+          - django~=5.0.0
+          - django~=5.1.0
+          - django~=5.2rc0


Suggested change

- django~=5.2rc0

- django~=5.2.0

nemesifier · 2025-04-02T21:43:19Z

.github/workflows/ci.yml

+          - python-version: "3.9"
+            django-version: django~=5.1.0
+          - python-version: "3.9"
+            django-version: django~=5.2rc0


Suggested change

django-version: django~=5.2rc0

django-version: django~=5.2.0

nemesifier · 2025-04-02T21:44:00Z

setup.py

    extras_require={
        'test': [
            (
                'openwisp-utils[qa]'
                ' @ https://github.com/openwisp/openwisp-utils/tarball/1.2'
            ),
-            'django-extensions~=3.2.0',
+            'django-extensions>=3.2.0,<=3.2.3',


I don't think this is necessary, if you think is necessary, can you please explain why?

Since the latest version of django-extensions is currently 3.2.3,Pinning to <=3.2.3 ensures we only use tested versions (avoids surprises if a buggy 3.2.4 is released later). i will update it to the old one.

@Eeshu-Yadav Not breaking changes are not included in minor version

setup.py

nemesifier · 2025-04-02T21:44:56Z

setup.py

+        'Programming Language :: Python :: 3.10',
+        'Programming Language :: Python :: 3.11',
+        'Programming Language :: Python :: 3.12',
+        'Programming Language :: Python :: 3.13 :: Only',


Are you sure of this? I think it should be:

Suggested change

'Programming Language :: Python :: 3.13 :: Only',

'Programming Language :: Python :: 3.13',

…wisp#38 Added: - Support for Django >=5.1,<5.3 - Support for Python 3.12, 3.14 Removed: - Support for Python < 3.9 - Support for Django < 4.2 Closes openwisp#38

Eeshu-Yadav · 2025-04-02T22:18:47Z

@nemesifier all the changes are done

Django 5.0 is EOL

pandafy

@Eeshu-Yadav I have made some minor changes in d602fc4 so we can quickly move forward with merging this PR. Kindly refer them when you make a PR for other modules.

@nemesifier I have tested this with OpenWISP Controller and I don't see any anomalies.

pandafy · 2025-04-04T13:40:12Z

.github/workflows/ci.yml

@@ -14,24 +14,53 @@ jobs:

  build:
    name: Python==${{ matrix.python-version }} | ${{ matrix.django-version }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest


Suggested change

runs-on: ubuntu-latest

runs-on: ubuntu-24.04

We are explicitly mentioning the Ubuntu version in CI across all modules of OpenWISP. Let's keep that for consistency.

okk will change it to 24.04 in other modules , if i work on the ci.yml part.

pandafy · 2025-04-04T13:57:16Z

.github/workflows/ci.yml

          - django~=4.2.0
+          - django~=5.1.0


Django 5.0 is EOL https://www.djangoproject.com/download/#unsupported-versions

Eeshu-Yadav added 2 commits April 2, 2025 14:14

Updated CI workflow and setup.py

d009356

Merge upstream/master into deps/django-5-python-3-support-35

65dcb65

pandafy added this to OpenWISP Contributor's Board Apr 2, 2025

github-project-automation bot moved this to To do (general) in OpenWISP Contributor's Board Apr 2, 2025

pandafy self-requested a review April 2, 2025 15:05

pandafy reviewed Apr 2, 2025

View reviewed changes

pandafy requested changes Apr 2, 2025

View reviewed changes

github-project-automation bot moved this from To do (general) to In progress in OpenWISP Contributor's Board Apr 2, 2025

codesankalp reviewed Apr 2, 2025

View reviewed changes

[deps] Add support for Django 5.1-5.3 and Python 3.12-3.14 openwisp#38

1b11740

Added: - Support for Django >=5.1,<5.3 - Support for Python 3.12, 3.14 Removed: - Support for Python < 3.9 - Support for Django < 4.2 Closes openwisp#38

Eeshu-Yadav force-pushed the deps/django-5-python-3-support-35 branch from 669446e to 1b11740 Compare April 2, 2025 21:36

nemesifier requested changes Apr 2, 2025

View reviewed changes

[deps] Add support for Django >=5.1,<5.3 and Python >=3.12, 3.14 open…

7620d73

…wisp#38 Added: - Support for Django >=5.1,<5.3 - Support for Python 3.12, 3.14 Removed: - Support for Python < 3.9 - Support for Django < 4.2 Closes openwisp#38

Aryamanz29 mentioned this pull request Apr 3, 2025

[deps] Add support for Django >=5.1,<5.3 and Python >=3.12, 3.14 #184 openwisp/openwisp-ipam#185

Merged

4 tasks

pandafy self-requested a review April 4, 2025 13:39

[ci] Removed Django 5.0 build, use ubuntu-24.04 runner image

d602fc4

Django 5.0 is EOL

pandafy approved these changes Apr 4, 2025

View reviewed changes

pandafy moved this from In progress to Needs review in OpenWISP Contributor's Board Apr 4, 2025

nemesifier approved these changes Apr 4, 2025

View reviewed changes

github-project-automation bot moved this from Needs review to In progress in OpenWISP Contributor's Board Apr 4, 2025

nemesifier merged commit e54aa03 into openwisp:master Apr 4, 2025
15 checks passed

github-project-automation bot moved this from In progress to Done in OpenWISP Contributor's Board Apr 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[deps] Add Django 5.x & Python 3.11-3.13 support, drop Django 3.2/Python 3.8 #38

[deps] Add Django 5.x & Python 3.11-3.13 support, drop Django 3.2/Python 3.8 #38

Eeshu-Yadav commented Apr 2, 2025 •

edited

Loading

pandafy Apr 2, 2025

pandafy left a comment

codesankalp Apr 2, 2025

nemesifier Apr 2, 2025

Eeshu-Yadav commented Apr 2, 2025

nemesifier Apr 2, 2025

nemesifier Apr 2, 2025

nemesifier Apr 2, 2025

Eeshu-Yadav Apr 2, 2025

devkapilbansal Apr 3, 2025

nemesifier Apr 2, 2025

Eeshu-Yadav commented Apr 2, 2025

pandafy left a comment

pandafy Apr 4, 2025

Eeshu-Yadav Apr 4, 2025

pandafy Apr 4, 2025

	'Programming Language :: Python :: 3.13 :: Only',
	'Programming Language :: Python :: 3.13',

[deps] Add Django 5.x & Python 3.11-3.13 support, drop Django 3.2/Python 3.8 #38

[deps] Add Django 5.x & Python 3.11-3.13 support, drop Django 3.2/Python 3.8 #38

Conversation

Eeshu-Yadav commented Apr 2, 2025 • edited Loading

Description

Checklist

Choose a reason for hiding this comment

pandafy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eeshu-Yadav commented Apr 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eeshu-Yadav commented Apr 2, 2025

pandafy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eeshu-Yadav commented Apr 2, 2025 •

edited

Loading