[XLA:SPMD] Optimize the partitioning for element-wise operations when all operands share the same sharding. #22910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_727116785
branch
from
d21aafb to
08048b1
Compare
… all operands share the same sharding. Let us take `C with S3 = add(A with S1, B with S2)` as an example, where A, B, C are tensors, S1, S2, S3 are their shardings. Before this change, we always have ``` A with S3 = reshard(A with S1, new_sharding=S3) B with S3 = reshard(B with S2, new_sharding=S3) C with S3 = add(A with S3, B with S3) ``` With this cl, if S1 and S2 are the same, we will have ``` C with S1 = add(A with S1, B with S1) C with S3 = reshard(C with S1) ``` The new partitioning method can reduce the number of reshards. PiperOrigin-RevId: 729930762
copybara-service
bot
force-pushed
the
test_727116785
branch
from
08048b1 to
ad0814d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:SPMD] Optimize the partitioning for element-wise operations when all operands share the same sharding.
Let us take
C with S3 = add(A with S1, B with S2)as an example, where A, B, C are tensors, S1, S2, S3 are their shardings.Before this change, we always have
With this cl, if S1 and S2 are the same, we will have
The new partitioning method can reduce the number of reshards.