PR #22822: Fix ambiguous constructor call in SourceTargetPairs initialization #23044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_730590032
branch
from
45d3c82 to
f0fa5d1
Compare
…lization Imported from GitHub PR #22822 ### Description Resolve a build failure (with GCC-11) in `collective_permute_cycle_test` caused by an ambiguous constructor call when initializing `SourceTargetPairs` with an empty list (`{{}}`). #### Issue When calling `SourceTargetPairs({{}})`, the compiler could not determine whether to use the `std::vector<std::pair<int64_t, int64_t>>` constructor or the default copy/move constructors, leading to an error: ``` xla/service/collective_permute_cycle_test.cc:130:48: error: call of overloaded 'SourceTargetPairs(<brace-enclosed initializer list>)' is ambiguous 130 | EXPECT_EQ(GetCycleType(SourceTargetPairs({{}})), CycleType::kNone); ``` #### Solution 1. Explicitly define an `initializer_list` constructor for `SourceTargetPairs` to properly handle `{}` and `{{src, tgt}}` initializations. 2. Update the test case to use default ctor `SourceTargetPairs()` instead of `SourceTargetPairs({{}})`, ensuring clarity and correctness. This fix ensures proper initialization and eliminates ambiguity Tested with GCC-11 Copybara import of the project: -- f97c38d by Alexander Pivovarov <[email protected]>: Fix ambiguous constructor call in SourceTargetPairs initialization Merging this change closes #22822 COPYBARA_INTEGRATE_REVIEW=#22822 from apivovarov:fix_source_target_pairs f97c38d PiperOrigin-RevId: 730610452
copybara-service
bot
force-pushed
the
test_730590032
branch
from
f0fa5d1 to
d4b3756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #22822: Fix ambiguous constructor call in SourceTargetPairs initialization
Imported from GitHub PR #22822
Description
Resolve a build failure (with GCC-11) in
collective_permute_cycle_testcaused by an ambiguous constructor call when initializingSourceTargetPairswith an empty list ({{}}).Issue
When calling
SourceTargetPairs({{}}), the compiler could not determine whether to use thestd::vector<std::pair<int64_t, int64_t>>constructor or the default copy/move constructors, leading to an error:Solution
initializer_listconstructor forSourceTargetPairsto properly handle{}and{{src, tgt}}initializations.SourceTargetPairs()instead ofSourceTargetPairs({{}}), ensuring clarity and correctness.This fix ensures proper initialization and eliminates ambiguity
Tested with GCC-11
Copybara import of the project:
--
f97c38d by Alexander Pivovarov [email protected]:
Fix ambiguous constructor call in SourceTargetPairs initialization
Merging this change closes #22822
FUTURE_COPYBARA_INTEGRATE_REVIEW=#22822 from apivovarov:fix_source_target_pairs f97c38d