PR #22953: Fix const qualifier on status prevents automatic move semantics #23055
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_730627732
branch
from
1cd0869 to
a555893
Compare
…ntics Imported from GitHub PR #22953 reason for change - const qualifier on `status` prevents automatic move semantics in return. When return status; is executed, the compiler cannot invoke the move constructor of `absl::Status` because status is const. Copybara import of the project: -- b172231 by Alexander Pivovarov <[email protected]>: Fix const qualifier on status prevents automatic move semantics Merging this change closes #22953 COPYBARA_INTEGRATE_REVIEW=#22953 from apivovarov:fix_rnvo b172231 PiperOrigin-RevId: 730686035
copybara-service
bot
force-pushed
the
test_730627732
branch
from
a555893 to
b613a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #22953: Fix const qualifier on status prevents automatic move semantics
Imported from GitHub PR #22953
reason for change - const qualifier on
statusprevents automatic move semantics in return.When return status; is executed, the compiler cannot invoke the move constructor of
absl::Statusbecause status is const.Copybara import of the project:
--
b172231 by Alexander Pivovarov [email protected]:
Fix const qualifier on status prevents automatic move semantics
Merging this change closes #22953
FUTURE_COPYBARA_INTEGRATE_REVIEW=#22953 from apivovarov:fix_rnvo b172231