Skip to content

Trying A/B tests for previous bugs. #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Trying A/B tests for previous bugs. #1888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions xprof/convert/xplane_to_tools_data.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,11 @@ absl::StatusOr<std::string> ConvertMultiXSpacesToToolData(
} else if (tool_name == "megascale_stats") {
return ConvertDcnCollectiveStatsToToolData(session_snapshot, options);
} else if (tool_name == "tool_names") {
TF_ASSIGN_OR_RETURN(bool hlo_proto_status,
ConvertMultiXSpaceToHloProto(session_snapshot));
if (!hlo_proto_status) {
return absl::NotFoundError("No HLO proto found in XSpace.");
}
return GetAvailableToolNames(session_snapshot);
} else if (tool_name == "_xplane.pb") { // internal test only.
return PreprocessXSpace(session_snapshot);
Expand Down