Skip to content

⌨️ Fix Typo: Memmory → Memory #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⌨️ Fix Typo: Memmory → Memory #1930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions xprof/utils/performance_info_wrapper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ limitations under the License.
namespace tensorflow {
namespace profiler {

MemoryAccessBreakdown PerformanceInfoWrapper::GetMemmoryAccessBreakdown()
const {
MemoryAccessBreakdown PerformanceInfoWrapper::GetMemoryAccessBreakdown() const {
MemoryAccessBreakdown breakdown;
for (const auto& m : performance_info_->memory_accessed_breakdown()) {
auto* memory_access = breakdown.add_memory_accessed();
Expand Down
2 changes: 1 addition & 1 deletion xprof/utils/performance_info_wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class PerformanceInfoWrapper {

// Convert XLA's memory access breakdown into TF's counterpart.
// TODO(b/408280338) code cleanup.
tensorflow::profiler::MemoryAccessBreakdown GetMemmoryAccessBreakdown() const;
tensorflow::profiler::MemoryAccessBreakdown GetMemoryAccessBreakdown() const;

private:
PerformanceInfoWrapper(std::unique_ptr<PerfInfoType> performance_info,
Expand Down
2 changes: 1 addition & 1 deletion xprof/utils/performance_info_wrapper_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ TEST(PerformanceInfoWrapper, TestMemoryAccessed) {
std::unique_ptr<PerformanceInfoWrapper> performance_info_wrapper =
PerformanceInfoWrapper::Create(std::move(performance_info));
#if defined(PLATFORM_GOOGLE)
EXPECT_THAT(performance_info_wrapper->GetMemmoryAccessBreakdown(),
EXPECT_THAT(performance_info_wrapper->GetMemoryAccessBreakdown(),
IgnoringRepeatedFieldOrdering(EqualsProto(R"pb(
memory_accessed {
operation_type: READ
Expand Down