Include missing newline in 'man' error#18183
Open
thatch wants to merge 1 commit intoopenzfs:masterfrom
Open
Conversation
Because the `strerror` result doesn't include a newline, we need to add one. Observed on a minimal system that doesn't have `man` installed, which behaves like this before the fix: ``` [root@upper tim]# zpool help import couldn't run man program: No such file or directory[root@upper tim]# ``` Signed-off-by: Tim Hatch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the
strerrorresult doesn't include a newline, we need to add one. Observed on a minimal system that doesn't havemaninstalled, which behaves like this before the fix:Motivation and Context
Displays a more readable error in the case where
mancan't be run. This is my first openzfs contribution and I'm happy to add tests or other changes with some hints about what's appropriate.Description
How Has This Been Tested?
Only manually, it's a string constant change...
Types of changes
Checklist:
Signed-off-by.