libzfs: improve error message for zpool create with ENXIO#18184
Open
chrislongros wants to merge 1 commit intoopenzfs:masterfrom
Open
libzfs: improve error message for zpool create with ENXIO#18184chrislongros wants to merge 1 commit intoopenzfs:masterfrom
chrislongros wants to merge 1 commit intoopenzfs:masterfrom
Conversation
When zpool create fails because a vdev cannot be opened (ENXIO), the error falls through to zpool_standard_error() which reports the generic 'one or more devices is currently unavailable'. This is misleading when the real cause is a block size mismatch or other device open failure. Add an explicit ENXIO case in zpool_create()'s error handling to provide a more descriptive message. Closes openzfs#11087 Signed-off-by: Christos Longros <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When zpool create fails because a vdev cannot be opened (ENXIO), the error falls through to zpool_standard_error() which reports the generic 'one or more devices is currently unavailable'. This is misleading when the real cause is a block size mismatch or other device open failure.
Add an explicit ENXIO case in zpool_create()'s error handling to provide a more descriptive message.
A companion kernel-side fix to return ZFS_ERR_ASHIFT_MISMATCH from spa_create() (matching the existing pattern in spa_vdev_add and spa_vdev_attach) is in progress as a separate PR.
Closes #11087