Skip to content

Conversation

@qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier marked this pull request as ready for review June 29, 2025 22:46
@qrkourier qrkourier requested a review from plorenz July 21, 2025 13:29
@qrkourier qrkourier force-pushed the add-promotion-card branch from ab866a4 to e0d5fe4 Compare July 23, 2025 23:47
@qrkourier qrkourier force-pushed the add-promotion-card branch from e0d5fe4 to 97c58ca Compare July 23, 2025 23:49
@qrkourier
Copy link
Member Author

qrkourier commented Jul 24, 2025

This PR needs GH Settings changes before checks can succeed:

  1. Set org Secret secrets.ZHOOK_URL_DEV_NOTIFICATIONS to the value provided by @qrkourier (to be recommended to users in lieu of generically-named ZHOOK_URL)
  2. Set org Secret secrets.ZHOOK_URL_GITHUB_SIG_CORE to the value provided by @qrkourier (to be used by use channel-specific mattermost incoming webhook urls sdk-golang#774)
  3. Set org Secret secrets.ZHOOK_URL to the value provided by @qrkourier (causes existing users to send webhooks to a Ziti-only intercept for the dev-notifications default channel)
  4. Set org Secret secrets.ZITI_MATTERMOST_IDENTITY to the HA-ready identity JSON provided by @qrkourier (this will cause webhooks to resume flowing via Ziti instead of the public address)

Note for users of this Action: the URL path part is the same as the old ZHOOK_URL, which is probably an org Secret, but that Mattermost Incoming Webhook has been reconfigured to lock it to a single channel, hence the change of name used by this Action's self-test workflow. GitHub repos that consume this Action may continue to use whichever env vars or GH Secrets they wish as inputs to the Action, but know that any which are using the value of org Secret ZHOOK_URL will be unable to override the destination channel by setting the channel input of the Action due to the aforementioned change locking that Incoming Webhook to a specific channel on the Mattermost server-side.

@qrkourier qrkourier changed the title add fips release handlers add fips release handlers; stop setting dest channel Jul 24, 2025
@qrkourier qrkourier requested a review from smilindave26 July 24, 2025 14:44
issueThumbnail = "https://github.com/openziti/branding/blob/main/images/ziggy/closeups/Ziggy-has-an-Idea-Closeup.png?raw=true"
# releaseThumbnail = "https://github.com/openziti/branding/blob/main/images/ziggy/png/Ziggy-Cash-Money-Closeup.png?raw=true"
releaseThumbnail = "https://github.com/openziti/branding/blob/main/images/ziggy/closeups/Ziggy-Parties-Closeup.png?raw=true"
fipsReleaseThumbnail = "https://github.com/openziti/branding/blob/main/images/ziggy/closeups/Ziggy-The-Cop-Closeup.png?raw=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything 'fips-related' doesn't feel like it really fits in here to me.

@qrkourier qrkourier closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants