Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add webhook validators #1887

Closed

Conversation

perdasilva
Copy link
Contributor

Description

Depends on #1885

Adds additional bundle validators around csv webhook configuration by ensuring:

  • webhook configurations reference existing deployment specs
  • there are no two webhooks of the same type with the same name
  • conversion webhooks reference bundle owned crds

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Per Goncalves da Silva added 2 commits April 1, 2025 12:58
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@perdasilva perdasilva changed the title Add webhook validators ✨ Add webhook validators Apr 1, 2025
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6fa7ca5
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67ebd8e87d0e67000852e267
😎 Deploy Preview https://deploy-preview-1887--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the add-webhook-validators branch from ca45978 to c97f40a Compare April 1, 2025 11:38
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the add-webhook-validators branch from c97f40a to 6fa7ca5 Compare April 1, 2025 12:15
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 97.81022% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.62%. Comparing base (db164cc) to head (6fa7ca5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...l/operator-controller/rukpak/convert/registryv1.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1887      +/-   ##
==========================================
+ Coverage   68.98%   69.62%   +0.63%     
==========================================
  Files          66       67       +1     
  Lines        5243     5366     +123     
==========================================
+ Hits         3617     3736     +119     
- Misses       1395     1398       +3     
- Partials      231      232       +1     
Flag Coverage Δ
e2e 50.24% <45.25%> (-0.30%) ⬇️
unit 57.52% <93.43%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant