Show image in MAS enterprise banner - #24438
Open
EinLama wants to merge 2 commits into
Open
Conversation
toy
requested changes
Jul 24, 2026
toy
left a comment
toy
left a comment
Contributor
There was a problem hiding this comment.
Maybe also better to wait if images will get updated https://community.openproject.org/projects/MAW/work_packages/MAW-3875/activity#comment-1708837
Contributor
There was a problem hiding this comment.
I think with_enterprise_banner_guard helper should be used instead, as otherwise there is no inline banner for trial token
<% with_enterprise_banner_guard :multiple_active_sprints, variant: :large, image: "enterprise/multiple-active-sprints-light.png", dark_image: "enterprise/multiple-active-sprints-dark.png" do %>
Contributor
Author
There was a problem hiding this comment.
Good point! Adjusted 👍
This also caters for trialing tokens
toy
approved these changes
Jul 27, 2026
toy
left a comment
toy
left a comment
Contributor
There was a problem hiding this comment.
Works as expected
Concerning https://community.openproject.org/projects/MAW/work_packages/MAW-3875/activity#comment-1708837, I think either merge and create a ticket to update images or wait for new images, up to you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/MAW-3875
What are you trying to accomplish?
Show an image for the Enterprise upsell banner for multiple active sprints.
Screenshots
Light mode
Dark mode
What approach did you choose and why?
Added the assets to the module code (see
engine.rb) so that the core does not know anything about the module.Merge checklist