Skip to content

[OP-19816] Booleans should be allowed as input for calculated values - #24443

Open
toy wants to merge 1 commit into
release/17.7from
bug/op-19816-booleans-should-be-allowed-as-input-for-calculated-values
Open

[OP-19816] Booleans should be allowed as input for calculated values#24443
toy wants to merge 1 commit into
release/17.7from
bug/op-19816-booleans-should-be-allowed-as-input-for-calculated-values

Conversation

@toy

@toy toy commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/OP-19816

What are you trying to accomplish?

Allow boolean project attributes to be used in calculated values

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy
toy force-pushed the bug/op-19816-booleans-should-be-allowed-as-input-for-calculated-values branch from cd8f6ad to 47f09e4 Compare July 24, 2026 19:10
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/projects/creation_wizard/wizard_from_template_flow_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24443, linked for reference only):

- `rspec ./spec/features/projects/creation_wizard/wizard_from_template_flow_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #24443. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24443 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @toy to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @toy, and request a review from @toy.
On every commit, set @toy as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant