Skip to content

Bump Primer to 0.90.1, Octicons to 19.36.0 - #24456

Draft
myabc wants to merge 2 commits into
release/17.7from
housekeeping/bump-primer-0.90.1
Draft

Bump Primer to 0.90.1, Octicons to 19.36.0#24456
myabc wants to merge 2 commits into
release/17.7from
housekeeping/bump-primer-0.90.1

Conversation

@myabc

@myabc myabc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Ticket

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Check Blankslates — 0.90.0 drops the heading to --text-title-size-small, the body text to --text-body-size-medium, and removes the @container (max-width: 34rem) padding block, so narrow containers keep full padding. ~71 call sites; worth eyeballing the hover card, split view, date picker dialog and widget boxes.
  • Check collapsible BorderBox headers — the toggle is now a real Primer::Beta::Button (data-collapsible-toggle, aria-labelledby) instead of a role="button" div, toggleViaKeyboard is gone, and count lost its default mr: 2. Verify click + keyboard toggling and header spacing in meetings, wikis and backlogs.
  • Run the feature specs that drive .CollapsibleHeader (meetings, wikis, backlogs) — modules/meeting/spec/support/pages/meetings/show.rb clicks the header element directly, and the click target moved.
  • Decide on modules/wikis/app/components/wikis/collapsible_page_links_component.html.erb: it omits collapsible_id, so the new toggle button renders an empty aria-controls (and trips the deprecation warning).
  • Sanity-check user-supplied URLs that end up in a Primer hrefBaseComponent now raises ArgumentError outside production for javascript:/vbscript: schemes (nils the attribute in production).
  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc
myabc force-pushed the housekeeping/bump-primer-0.90.1 branch from 0e4133a to df3e037 Compare July 27, 2026 12:07
@HDinger

HDinger commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Since this contains a bug fix for 17.7 , it should proabably target the release branch

@HDinger HDinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we messed somthing up with line height when making the chevron a real button
Image

@myabc
myabc force-pushed the housekeeping/bump-primer-0.90.1 branch from df3e037 to 1a9970b Compare July 27, 2026 13:01
@myabc
myabc changed the base branch from dev to release/17.7 July 27, 2026 13:01
@myabc
myabc requested a review from Copilot July 27, 2026 13:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates OpenProject’s Primer/ViewComponent and Octicons dependencies (Ruby gems + frontend npm packages) to newer patch/minor releases, and aligns an existing RichTextArea form spec with the updated label for/field id behavior.

Changes:

  • Bump openproject-primer_view_components to 0.90.1 and openproject-octicons/_helper to 19.36.0 in Ruby (Gemfile + lockfile).
  • Bump corresponding frontend packages (@openproject/primer-view-components, @openproject/octicons-angular, and the @primer/view-components alias) to the same versions (package.json + lockfile).
  • Update Primer::OpenProject::Forms::RichTextArea spec to remove the pending and assert the new namespaced label for value.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/lib/primer/open_project/forms/rich_text_area_spec.rb Updates expectations for label for values after Primer bump; removes prior pending.
Gemfile Bumps OpenProject-maintained Primer/Octicons gem version constraints.
Gemfile.lock Locks bumped gem versions and updated dependency constraints/checksums.
frontend/package.json Bumps frontend Primer/Octicons package versions (including @primer/view-components alias).
frontend/package-lock.json Locks bumped npm package versions and updated metadata/peer dependency ranges.
Files not reviewed (1)
  • frontend/package-lock.json: Generated file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants