Skip to content

[FND-180] Clean up workflows step - #24457

Draft
mrmir wants to merge 1 commit into
devfrom
implementation/fnd-180-clean-up-workflows-step
Draft

[FND-180] Clean up workflows step #24457
mrmir wants to merge 1 commit into
devfrom
implementation/fnd-180-clean-up-workflows-step

Conversation

@mrmir

@mrmir mrmir commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/FND-180

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Comment thread app/components/work_package_types/wizard/page_component.html.erb
@mrmir
mrmir force-pushed the implementation/fnd-180-clean-up-workflows-step branch 4 times, most recently from 406cc6c to 603be62 Compare July 27, 2026 15:45
@mrmir
mrmir force-pushed the implementation/fnd-180-clean-up-workflows-step branch from 603be62 to 6580add Compare July 28, 2026 06:59
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]
  • rspec ./modules/team_planner/spec/features/query_handling_spec.rb[1:3:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24457, linked for reference only):

- `rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]`
- `rspec ./modules/team_planner/spec/features/query_handling_spec.rb[1:3:1:1]`

Treat this as a standalone task, unrelated to PR #24457. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24457 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @mrmir to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @mrmir, and request a review from @mrmir.
On every commit, set @mrmir as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants