ci(lint): exclude goconst linter from test files - #895
Merged
artek-koltun merged 1 commit intoJul 15, 2026
Conversation
tfrankow-intel
force-pushed
the
fix/exclude-goconst-test-files
branch
from
July 15, 2026 14:09
997dcad to
12a775b
Compare
Repeated string literals in table-driven tests are idiomatic Go and do not need to be extracted into constants. This suppresses 385 goconst warnings that only appear in _test.go files. Also set goconst ignore-tests so test-file occurrences are not counted toward the threshold for production code strings, and raise min-occurrences to 4 to avoid false positives on strings like "TBD" that appear only a few times in production code. Signed-off-by: Frankowski, Tomasz <tomasz.frankowski@intel.com>
tfrankow-intel
force-pushed
the
fix/exclude-goconst-test-files
branch
from
July 15, 2026 14:53
12a775b to
f1eb1c5
Compare
artek-koltun
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated string literals in table-driven tests are idiomatic Go and do not need to be extracted into constants. This suppresses 385 goconst warnings that only appear in _test.go files.