-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenVPN - Enhance tunnel networks with nopool and dedicated ifconfig-… #7568
Open
Reiner030
wants to merge
13
commits into
opnsense:master
Choose a base branch
from
Reiner030:OpenVPN_working_Static_IP_addresses_for_VPN_clients_#7567
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OpenVPN - Enhance tunnel networks with nopool and dedicated ifconfig-… #7568
Reiner030
wants to merge
13
commits into
opnsense:master
from
Reiner030:OpenVPN_working_Static_IP_addresses_for_VPN_clients_#7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tify remote IP for authentication
…eset active Else Windows client can't connect+route with wrong default topology_subnet parameter, has yet no push_register_dns and no keepalive parameters available for override Additionally --push-remove opt could be implemented as a better alternative for push-reset: https://openvpn.net/community-resources/reference-manual-for-openvpn-2-4/ --push-remove opt selectively remove all --push options matching "opt" from the option list for a client. "opt" is matched as a substring against the whole option string to-be-pushed to the client, so --push-remove route would remove all --push route ... and --push route-ipv6 ... statements, while --push-remove 'route-ipv6 2001:' would only remove IPv6 routes for 2001:... networks. -push-remove can only be used in a client-specific context, like in a --client-config-dir file, or --client-connect script or plugin -- similar to --push-reset, just more selective. NOTE: to change an option, --push-remove can be used to first remove the old value, and then add a new --push option with the new value.
usage dependencies. Actually difficult to find the "correct" password+otp_token order because mainly OpenSense matches with the "wrong" order where found and the RFC writes only about Kerberos Authentication which is totally different. But here examples for the order password+otp_token knew since years: https://download.fudosecurity.com/documentation/fudo/5_1/online_help/en/main/en/users_auth_oath.html https://networkjutsu.com/freeradius-google-authenticator/ https://github.com/evgeny-gridasov/openvpn-otp https://docs.rcdevs.com/howtos/pfsense/pfsense/ https://docs.rcdevs.com/howtos/radius_bridge/rb_manual/ https://www.netgate.com/blog/freeradius-on-pfsense-for-2fa so maybe bests the authenticate() function / calls needs to be extended from (user, password) to (user, password, otp_token) to avoid unneccesary copy/extract/reorder processes which seems to be only in these files: src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php src/opnsense/mvc/app/library/OPNsense/Auth/IAuthConnector.php src/opnsense/mvc/app/library/OPNsense/Auth/API.php src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php src/opnsense/mvc/app/library/OPNsense/Auth/Local.php src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php src/opnsense/scripts/openvpn/user_pass_verify.php src/www/diag_authentication.php src/www/xmlrpc.php
* "keepalive 10 60" was fix setup in line opnsense#528 of openvpn.inc so GUI based "Keep alive interval" and "Keep alive timeout" fields couldn't be used. * also both variables keepalive-interval and keepalive-timeout were overseen for setup in OpenVPN.php for writing config file
…pool + ifconfig-ipv6-pool parameters to give static IP client overrides a chance to use an unallocated IP
…pool + ifconfig-ipv6-pool parameters to give static IP client overrides a chance to use an unallocated IP
2 tasks
This commit/PR depends on PR opnsense@5f13d0a in file src/etc/inc/plugins.inc.d/openvpn.inc which was line 999-1001 and is actual line 991-993: if (!empty($server['topology_subnet'])) { $conf .= "push \"topology subnet\"\n"; }
AdSchellevis
force-pushed
the
master
branch
5 times, most recently
from
December 3, 2024 15:53
6586a65
to
607e32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pool + ifconfig-ipv6-pool parameters to give static IP client overrides a chance to use an unallocated IP