Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pythonpath config for pytest #133

Closed
wants to merge 1 commit into from
Closed

Conversation

alexzurbonsen
Copy link
Contributor

@alexzurbonsen alexzurbonsen commented Jul 4, 2024

"Fixes" all the tests.

@alexzurbonsen alexzurbonsen changed the title fix impmort paths for opossum_lib [WIP] fix import paths for opossum_lib Jul 4, 2024
@alexzurbonsen alexzurbonsen marked this pull request as ready for review July 6, 2024 11:51
@alexzurbonsen alexzurbonsen changed the title [WIP] fix import paths for opossum_lib fix import paths for opossum_lib Jul 6, 2024
@alexzurbonsen alexzurbonsen changed the title fix import paths for opossum_lib fix pythonpath config for pytest Jul 6, 2024
@meretp
Copy link
Contributor

meretp commented Jul 18, 2024

Why is that needed? For me on linux the tests work as expected

@meretp meretp self-requested a review July 18, 2024 08:52
@alexzurbonsen
Copy link
Contributor Author

Mysterious. I swear imports couldn't be resolved when I was running this back then. 😅 But now it also works for me without this change.

I don't know what changed though. Our doc said that test are broken somehow, so I thought failing tests are expected. But that seemed to have fixed itself. Did we update pytest may be?

@meretp
Copy link
Contributor

meretp commented Jul 18, 2024

I was surprised to see this in the doc and thought it referred to the CI being red which you already fixed in the other diff. If it works for you without these changes now, I would abandon this diff for now and we can still merge it if the problem reappears.

@alexzurbonsen
Copy link
Contributor Author

Yes, I agree.

@mstykow mstykow deleted the fix-tests branch January 3, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants