Feat force option for oppossum file #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hellgartner
force-pushed
the
feat-force-option-for-oppossum-file
branch
from
5073ac6 to
b300414
Compare
|
tbh, i don't really see the value of this option. what's the problem with silently dropping the output file? |
|
I think having the error is more defensive. Someone might think that the conversion of opossum -> opossum should be essentially a no-op and that is partially true. It is wrong when there is a output.json because that information just gets destroyed. |
Hellgartner
force-pushed
the
feat-force-option-for-oppossum-file
branch
from
b300414 to
b4e3eb1
Compare
Generated using datamodel-code-generator
* opossum file:= input.json + output.json * The output path is not yet used
Note: To make this work in all the tests the mypy pydantic plugin needed to be included
* Reason for ignoring typing * Creating the invalid structure is temporary * It is explicitly revalidated afterward * For testing, explicitly invalid structures are created
abraemer
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opossum file parsing #49 there is the desire to add a --force or similar option to just ignore the output.json file in this case