[codex] Add close file menu item - #250
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
flashtype-website | 5343935 | Commit Preview URL Branch Preview URL |
Jun 29 2026, 10:34 PM |
samuelstroschein
marked this pull request as ready for review
June 29, 2026 22:29
samuelstroschein
force-pushed
the
codex/close-active-document-menu
branch
from
June 29, 2026 22:31
d7d481e to
3c33117
Compare
samuelstroschein
force-pushed
the
codex/close-active-document-menu
branch
from
June 29, 2026 22:33
3c33117 to
5343935
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note
Low Risk
Desktop menu and renderer tab-close wiring only; reuses existing close-view logic with no auth or persistence changes beyond menu refresh.
Overview
Adds a native File > Close File action on desktop, wired the same way as New File: the main process focuses the target workspace window and sends
workspace:closeFileto the renderer.The menu item is enabled only when that window has an active document (tracked via
activeFilePathsByWindowId), and the app menu is refreshed when the active file path changes so the control stays in sync. Preload and desktop types exposeonCloseFilefor the shell.V2LayoutShellsubscribes to that event and closes the active central tab through the existinghandleCloseViewpath. A layout-shell test covers the native close flow.Reviewed by Cursor Bugbot for commit 5343935. Bugbot is set up for automated code reviews on this repo. Configure here.