Skip to content

download links - #264

Merged
samuelstroschein merged 1 commit into
mainfrom
codex/first-party-download-links
Jul 3, 2026
Merged

download links#264
samuelstroschein merged 1 commit into
mainfrom
codex/first-party-download-links

Conversation

@samuelstroschein

@samuelstroschein samuelstroschein commented Jul 3, 2026

Copy link
Copy Markdown
Member

Note

Low Risk
Marketing-site download routing only; no auth, data, or backend changes beyond client-side redirects to GitHub.

Overview
Mac download CTAs now navigate to /download instead of resolving the GitHub release on click from the landing page.

A new DownloadHandoffPage loads the latest -mac-arm64.dmg URL via the existing GitHub API helper, auto-redirects after a short delay, and shows a manual Download for Mac link (falling back to the GitHub latest release page on failure). The landing page DownloadLink is simplified to a plain anchor to DOWNLOAD_URL; the async handleDownloadClick handler is removed.

Reviewed by Cursor Bugbot for commit 9dcb472. Bugbot is set up for automated code reviews on this repo. Configure here.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
flashtype-website 9dcb472 Commit Preview URL

Branch Preview URL
Jul 03 2026, 08:46 PM

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9dcb472. Configure here.

console.error(error);
redirectTimeout = setTimeout(() => {
window.location.replace(GITHUB_LATEST_RELEASE_URL);
}, DOWNLOAD_REDIRECT_DELAY_MS);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unmount still triggers error redirect

Medium Severity

After leaving the download handoff page, a failed latestMacDmgDownloadUrl call can still schedule window.location.replace to the GitHub latest release URL. The success path checks isCurrent before redirecting, but the catch block does not, so cleanup cannot stop a redirect started after unmount.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9dcb472. Configure here.

@samuelstroschein
samuelstroschein merged commit 293d4bb into main Jul 3, 2026
5 checks passed
@samuelstroschein
samuelstroschein deleted the codex/first-party-download-links branch July 3, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant