Skip to content

fix(message-format): preserve selectors, inputs, and local ordering - #4407

Merged
samuelstroschein merged 1 commit into
mainfrom
codex/fix-message-format-roundtrip
Aug 25, 2026
Merged

fix(message-format): preserve selectors, inputs, and local ordering#4407
samuelstroschein merged 1 commit into
mainfrom
codex/fix-message-format-roundtrip

Conversation

@samuelstroschein

Copy link
Copy Markdown
Member

Summary

  • Parse every selector match component independently so exported multi-selector messages reimport without whitespace-corrupted selector names or catchall values.
  • Continue discovering placeholders after an already-declared input, preventing missing message inputs and downstream compiler errors.
  • Export without mutating caller-owned declarations or variant matches, while preserving dependency order for chained local declarations.
  • Add focused regression coverage and a patch changeset for @inlang/plugin-message-format.

Verification

  • pnpm test in packages/plugins/inlang-message-format (64 passed, 1 skipped; includes TypeScript checking).
  • pnpm run build in packages/plugins/inlang-message-format.
  • Prettier check for all modified plugin TypeScript files.
  • Independent subagent reviews approved the importer and exporter changes.

@changeset-bot

changeset-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e9aa9ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@inlang/plugin-message-format Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
inlang-website e9aa9ed Commit Preview URL

Branch Preview URL
Aug 25 2026, 06:47 AM

@samuelstroschein
samuelstroschein merged commit 5fd9f83 into main Aug 25, 2026
2 checks passed
@samuelstroschein
samuelstroschein deleted the codex/fix-message-format-roundtrip branch August 25, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant