Add TCK showing using external bundle (h2) and a pax warapped (sqlite) - #273
Draft
laeubi wants to merge 1 commit into
Draft
Add TCK showing using external bundle (h2) and a pax warapped (sqlite)#273laeubi wants to merge 1 commit into
laeubi wants to merge 1 commit into
Conversation
laeubi
force-pushed
the
add_tck_tests
branch
from
December 28, 2022 07:26
4e84f34 to
e147284
Compare
Test Results102 tests +12 73 ✔️ - 8 2m 2s ⏱️ +9s For more details on these failures and errors, see this check. Results for commit d658720. ± Comparison against base commit 89cf4e3. This pull request removes 10 and adds 22 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
laeubi
force-pushed
the
add_tck_tests
branch
4 times, most recently
from
December 28, 2022 18:25
3358a43 to
d042c8e
Compare
Member
|
@laeubi the test failure is because Pax Exam tries to resolve just built artifacts, but the build workflow uses only I'm not sure how it's usually handled with Github Actions (I didn't analyze much how it works - I guess we can't simply use |
Member
Author
|
I think clean install would be fine if it is required here! |
Member
|
Can |
Member
|
@laeubi I'm getting: @laeubi I've merged your pr and added some cleanup and pushed the result to https://github.com/ops4j/org.ops4j.pax.jdbc/commits/main-tck - you can check it there (mind that Symbolic Name for Maria DB driver has changed!). If you make it work, it'd be great ;) |
Member
|
For now, I'm releasing 1.5.6 but without this TCK addition. |
Member
|
Ah, looks like |
Member
|
So the only failure is: But that's how your test works - it passes /**
* Checker method that will throw if any unsupported standard OSGi options
* is present.
*
* @param p the properties to check
* @throws SQLFeatureNotSupportedException if unsupported properties are
* present
*/
private static void rejectUnsupportedOptions(Properties p)
throws SQLFeatureNotSupportedException {
// Unsupported standard properties in OSGi
if (p.containsKey(DataSourceFactory.JDBC_ROLE_NAME)) {
throw new SQLFeatureNotSupportedException("The " +
DataSourceFactory.JDBC_ROLE_NAME +
" property is not supported by H2");
}
if (p.containsKey(DataSourceFactory.JDBC_DATASOURCE_NAME)) {
throw new SQLFeatureNotSupportedException("The " +
DataSourceFactory.JDBC_DATASOURCE_NAME +
" property is not supported by H2");
}
} |
Member
Author
|
@grgrzybek I think there was some discussions about the test is asserting wron things, sadly we need to wait for the next release for this fixes to become "live" maybe we can still include the test but somehow keep in mind it is okay to fail (maybe just as a warning?). |
Member
|
I can move this module to a non-active profile called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.