Deprecate Branch.has_schema_changes use Branch.schema_differs_from_default_branch - #10086
Draft
ogenstad wants to merge 1 commit into
Draft
Deprecate Branch.has_schema_changes use Branch.schema_differs_from_default_branch#10086ogenstad wants to merge 1 commit into
ogenstad wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 8 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Specification-only PR adding design documents, plans, and contracts for a future rename. No runtime code, config, or operational changes; change is bounded and clearly beneficial for planning and communication.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes
What changed
How to review
How to test
# Commands to validateImpact & rollout
Checklist
uv run towncrier create ...)Summary by cubic
Adds the full spec and implementation plan to deprecate
Branch.has_schema_changesand introduceschema_differs_from_default_branch, clarifying the field’s meaning while keeping a non-breaking path. This documents IFC-2281 and prepares backend, GraphQL, and UI changes; no runtime code changes are included in this PR.schema_differs_from_default_branchonBranchandInfrahubBranch; deprecatehas_schema_changeswith a reason naming the replacement and removal in 1.14.0, with strict value parity.schema_differs_from_default_branch) with the old property delegating to it; internal readers move to the new name; no logic changes.Written for commit 2c60fe8. Summary will update on new commits.