fix(search): point jina-code alias at published HF repo#1053
Conversation
The `jina-code` alias mapped to `Xenova/jina-embeddings-v2-base-code`, which 404s on Hugging Face. Point it at `jinaai/jina-embeddings-v2-base-code`, the published code embedding model, drop the stale "requires HF token" note in the README, and add a regression test for the alias. Fixes #1025.
|
Claude finished @carlos-alm's task —— View job PR Review CompleteReviewing PR #1053: fix(search): point jina-code alias at published HF repo Todo List:
Root Cause AnalysisProblem Being Solved: The Why This Approach: The fix correctly redirects the alias to Risk Assessment: Very low risk. This is a simple string replacement that fixes a broken external dependency reference. The change is well-tested with a regression test. Backlog Compliance
Code Quality AssessmentChanges Analysis:
Strengths:
Test Quality: test('jina-code points to the published code embedding model', () => {
expect(MODELS['jina-code'].name).toBe('jinaai/jina-embeddings-v2-base-code');
});This will catch any future regressions where the alias gets pointed back to the wrong repository. Technical Verification:
Minor Observations
Final Recommendation
The PR successfully resolves issue #1025 and restores working semantic search functionality for code-specific embeddings. |
Greptile SummaryThis PR fixes the broken Confidence Score: 5/5Safe to merge — minimal, targeted fix with no logic changes beyond the broken alias Single-line model-name fix backed by a regression test and a matching README cleanup; no logic, API, or schema changes; no issues found No files require special attention Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["User requests 'jina-code' model"] --> B["getModelConfig('jina-code')"]
B --> C["MODELS['jina-code'].name"]
C -->|Before PR| D["Xenova/jina-embeddings-v2-base-code\n(404 on HuggingFace)"]
C -->|After PR| E["jinaai/jina-embeddings-v2-base-code\n(public, published repo)"]
E --> F["loadModel → HuggingFace download"]
F --> G["Embeddings generated"]
Reviews (1): Last reviewed commit: "fix(search): point jina-code alias at pu..." | Re-trigger Greptile |
Summary
jina-codetojinaai/jina-embeddings-v2-base-code(the published code embedding model). The previous aliasXenova/jina-embeddings-v2-base-code404s on Hugging Face.Fixes #1025.
Test plan
npx vitest run tests/search/embedding-strategy.test.ts(26/26 pass, including the new test)npx tsc --noEmitnpx biome check src/domain/search/models.ts tests/search/embedding-strategy.test.ts