-
Notifications
You must be signed in to change notification settings - Fork 10
fix(native): bump tree-sitter to 0.25 + ABI regression test (#1054) #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+141
−8
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3dad391
fix(native): bump tree-sitter to 0.25 to match grammar ABI 15
carlos-alm ecef808
Merge remote-tracking branch 'origin/main' into fix/issue-1054-tree-s…
carlos-alm 122da28
test(native): name EXPECTED_LEN constant and improve assert message (…
carlos-alm b7fa204
ci: clarify clang step is redundant after tree-sitter ABI fix (#1060)
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert_eq!(LanguageKind::all().len(), 24)check doesn't fully close the gap it aims to close. If a developer adds a new variant to the enum (forced by the compile-time match) but forgets to add it toall()and also forgets to bump this count, both the compile check and the runtime assertion pass silently — the new language gets zero ABI coverage. The assertion only catches someone who updatesall()but forgets to bump the number, which is the less dangerous case. Naming the constant and improving the assertion message would make the three required update sites more explicit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 122da28 — applied the suggested EXPECTED_LEN constant rename and the clearer assertion message verbatim. Both regression tests still pass locally.