-
Notifications
You must be signed in to change notification settings - Fork 10
ci: run pre-publish benchmark gate on every PR #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlos-alm
wants to merge
12
commits into
main
Choose a base branch
from
ci/regression-gate-on-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
20884c2
ci: run pre-publish benchmark gate on every PR
carlos-alm 054b78d
Merge branch 'main' into ci/regression-gate-on-pr
carlos-alm fda3c4f
test(bench): mark 3.9.6 incremental Full build as known regression (#…
carlos-alm 9aca6db
ci: scope benchmark gate to PRs and add per-step timeouts (#1072)
carlos-alm e8614e6
Merge branch 'main' into ci/regression-gate-on-pr
carlos-alm dbd48ae
fix(bench): bypass version-gap check when latest is 'dev' (#1072)
carlos-alm dcee140
Merge branch 'main' into ci/regression-gate-on-pr
carlos-alm 4371bd2
Merge remote-tracking branch 'origin/main' into ci/regression-gate-on-pr
carlos-alm 3cf32b1
fix(bench): look up KNOWN_REGRESSIONS by baseline version when latest…
carlos-alm 46492cf
test(bench): mark 3.9.6 1-file rebuild as known regression (#1072)
carlos-alm 7cbe93e
Merge remote-tracking branch 'origin/main' into ci/regression-gate-on-pr
carlos-alm cf7ca99
Merge branch 'main' into ci/regression-gate-on-pr
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The four benchmark run steps (
Run build benchmark,Run resolution benchmark,Run query benchmark,Run incremental benchmark) have notimeout-minutes, unlikeGate on resolution thresholds(30 min) andRun tracer validation(10 min). If any benchmark script hangs — for example due to an unresponsive subprocess or an infinite loop in new code — the job will occupy the runner for up to 6 hours before GitHub kills it, blocking theci-pipelinegate for the entire duration. The equivalent steps inpublish.ymlshare the same gap. Adding per-step timeouts (e.g., 15–20 min each) keeps a stuck job from becoming a multi-hour blocker.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 9aca6db — added
timeout-minutes: 20to all four benchmark execution steps (build / resolution / query / incremental) so a hung script can't hold the runner for the GitHub default 6 hours. Same caveat carries over to publish.yml's equivalent steps; left untouched here per one-PR-one-concern (will follow up if needed).