-
Notifications
You must be signed in to change notification settings - Fork 11
fix(native): read mtime via BigInt nanoseconds to match Rust truncation #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test comment says "Reverting to
Math.floor(stat.mtimeMs)re-introduces the bug visibly," but that's only true when the freshly-created file'smtimeNshappens to land near a millisecond boundary where f64 rounding flips. At the current epoch (~1.748 × 10¹⁸ ns), the f64 ULP is ~256 ns, so only values with a sub-ms remainder in the ~[999744 ns, 1000000 ns) window trigger the discrepancy — roughly a 0.026% chance per run. In the common case the test passes even withMath.floor.A deterministic version would use
fs.utimesSyncto stamp a known-bad mtime (one whereMath.floor(Number(badNs) / 1e6) !== Number(badNs / 1_000_000n)) and assert the two values diverge, then confirmfileStatreturns the BigInt-truncated value. As written the test is still useful as a sanity check, but the regression-guard claim in the comment overstates it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 1a44aa4 — replaced the probabilistic test with a deterministic
vi.spyOn(fs, 'statSync')stub that injects a hand-pickedmtimeNs(1748400000000999808n) where the BigInt path lands onNand the f64 path lands onN+1. Verified locally by revertingfileStat()toMath.floor(stat.mtimeMs)— the test now fails deterministically (1748400000000 vs 1748400000001) instead of mostly passing. Kept the original fresh-file-on-disk variant alongside as a sanity check that the helper still works against real filesystem stats.