-
Notifications
You must be signed in to change notification settings - Fork 12
fix(bench): warmup + median for queryTimeMs to remove cold-start noise #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b46dab7
fix(bench): warmup + median for queryTimeMs to remove cold-start noise
carlos-alm de2212c
fix(bench): hoist QUERY_WARMUP_RUNS, warm benchQuery independently (#…
carlos-alm 3449e0d
Merge branch 'main' into fix/1113-query-time-methodology
carlos-alm 663ee19
fix: resolve merge conflicts with main
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
benchQueryparityThe comment says the new methodology matches "the per-target
queries.*Msblock below", butbenchQuery(used for allqueries.*Msvalues) has no explicit warmup loop of its own. The implicit warming works because thequeryTimeMswarmup runs execute beforebenchQueryis ever called, but that coupling is fragile — if the order of operations ever changes,queries.*Msloses its warm-up silently. Consider either adding a warmup insidebenchQuery, or rephrasing the comment to clarify that the warmup runs here also prime the DB/NAPI cache for the subsequentqueries.*Msblock.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in de2212c. Added an explicit warmup loop inside
benchQueryitself (3 runs, gated byQUERY_WARMUP_RUNS), so each call site primes its own NAPI/rusqlite/page-cache state. The methodology no longer depends on call ordering, andqueryTimeMsnow usesbenchQuerydirectly — the comment describing parity with thequeries.*Msblock is now accurate.