test(julia): cover macro signature guard branch

[carlos-alm]

Summary

• Adds does not record macro signature as call test to tests/parsers/julia.test.ts, mirroring the existing function-signature guard test for the macro_definition grandparent branch.
• Verified the test fails when the macro_definition branch is removed from handleCall in src/extractors/julia.ts, so it would catch a future tree-sitter-julia grammar regression on macros.

The test was prepared during PR #1130 review (commit 6ae097b on fix/1126-julia-wasm-extractor-bugs) but landed after the squash-merge, so it never reached this branch's history.

Closes #1137

Test plan

• npx vitest run tests/parsers/julia.test.ts — all 16 tests pass.
• Manually removed the macro_definition arm of the handleCall guard and confirmed the new test fails with expected [ 'mymac', 'println' ] to not include 'mymac', then restored.

[claude]

Claude finished @carlos-alm's task —— View job

---

PR Review: test(julia): cover macro signature guard branch

Todo List:

• Read the changed test file to understand the additions
• Examine the Julia extractor code to understand what's being tested
• Apply 5-phase review criteria
• Provide final assessment and rating

Root Cause Analysis

Problem Being Solved: This PR adds test coverage for the macro signature guard branch in the Julia extractor's handleCall function. The existing code at lines 382-385 in src/extractors/julia.ts has a guard that prevents macro definition signatures from being incorrectly recorded as function calls, but this specific branch was untested.

Why This Approach: The test mirrors the existing "does not record function signature as call" test (lines 143-153) but covers the macro_definition grandparent branch specifically. This ensures that macro signatures like macro mymac(x) don't get recorded as calls to mymac.

Risk Assessment: ✅ Low risk - This is a pure test addition that increases coverage of existing defensive logic.

Backlog Compliance

• Zero-dep: ✅ No new dependencies added
• Foundation-aligned: ✅ Improves test coverage of core parsing functionality
• Problem-fit: 4 - Prevents incorrect call extraction that would mislead AI agents about dependencies
• Breaking: No - Pure test addition
• Tier: 1

Code Quality Assessment

Test Implementation (lines 155-165): ✅ Excellent

• Follows the exact pattern of the existing function signature test
• Clear test name and comprehensive comment explaining the purpose
• Proper verification: asserts mymac is NOT in calls but println IS in calls
• Realistic Julia macro syntax

Coverage Validation: ✅ Strong

• PR description shows manual verification by removing the guard and confirming test failure
• Test specifically targets the grand?.type === 'macro_definition' branch at line 384

Code Consistency: ✅ Perfect

• Mirrors existing test pattern exactly
• Uses same assertion style as other Julia parser tests
• Maintains test suite organization and naming conventions

Guard Logic Analysis

The tested code (lines 382-385) correctly prevents this scenario:

macro mymac(x)
    println(x)
end

From incorrectly recording mymac as both a definition AND a call. The guard checks:

1. node.parent?.type === 'signature' - Call is part of a signature
2. grand?.type === 'macro_definition' - Grandparent is macro definition

This is critical for accurate dependency analysis - without this guard, macros would appear to call themselves, confusing the dependency graph.

Final Assessment

## Root Cause Analysis
**Problem Being Solved**: Test coverage gap for macro signature guard in Julia call extractor
**Why This Approach**: Mirrors existing function guard test pattern, validates defensive parsing logic
**Risk Assessment**: Low risk, pure test coverage improvement

## Backlog Compliance
- Zero-dep: ✅ - No new dependencies
- Foundation-aligned: ✅ - Improves core parsing accuracy
- Problem-fit: 4 - Prevents incorrect dependency extraction for AI agents
- Breaking: No - Test-only addition
- Tier: 1

## Critical Concerns
None - this is a well-implemented test addition with proper verification.

## Final Recommendation
- Rating: ⭐⭐⭐⭐☆ (4/5)
- Action: APPROVE
- Reasoning: Excellent test coverage addition with thorough manual verification, follows existing patterns perfectly, and addresses a real gap in macro handling test coverage.

Minor Note: The only reason this isn't 5/5 is that it's a straightforward test addition rather than solving a complex problem, but it's executed flawlessly.

[greptile-apps]

Greptile Summary

This PR adds a single regression test to the Julia parser test suite that guards against macro signature names being incorrectly recorded as function calls. The test directly mirrors the existing does not record function signature as call test, targeting the macro_definition branch of the handleCall guard in src/extractors/julia.ts.

• Adds does not record macro signature as call test, asserting mymac is absent from symbols.calls while println (a body call) is still present.
• The test is self-contained, well-commented, and was verified to fail when the macro_definition arm of the guard is removed — confirming it provides real regression coverage.

Confidence Score: 5/5

Test-only addition with no production code changes; safe to merge.

The change is a single, focused test that matches the shape of existing tests in the suite, exercises a real guard in the extractor, and was confirmed to catch a real regression. No production code is touched.

No files require special attention.

Important Files Changed

Filename	Overview
tests/parsers/julia.test.ts	Adds a single test verifying that macro_definition signatures are not recorded as calls; mirrors the existing function-signature guard test and correctly exercises the guard at line 384 of src/extractors/julia.ts.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["parseJulia(macro mymac(x)\n  println(x)\nend)"]
    B["tree-sitter-julia AST"]
    C["macro_definition node\n  └─ signature\n       └─ call_expression (mymac)"]
    D["handleCall(call_expression)"]
    E{"parent.type === 'signature'\nAND\ngrand.type === 'macro_definition'?"}
    F["return — skip recording\n✅ mymac NOT in calls"]
    G["body call_expression (println)"]
    H["handleCall(println)"]
    I["record call\n✅ println IN calls"]

    A --> B --> C
    C --> D --> E
    E -- yes --> F
    B --> G --> H --> I

Loading

_{Reviews (7): Last reviewed commit: "Merge branch 'main' into test/1137-julia..." | Re-trigger Greptile}