-
Notifications
You must be signed in to change notification settings - Fork 10
fix(build:wasm): add preflight check with clear remediation #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shell: truewith array args may mishandle paths with spacesexecFileSyncwithshell: truepasses the command to a shell, which joinscmdandargsinto a single string. AnygrammarDirpath containing spaces (common on Windows underC:\Users\First Last\...) will be split by the shell, causing a "no such directory" error rather than the expected WASM-toolchain or ENOENT message. This also existed in the original code but is now centralised inrunCaptured; wrapping path args in quotes whenshell: trueis set would harden both the preflight and the per-grammar builds.If
shell: trueis required fornpxresolution on Windows, consider usingspawnSyncwithshell: trueand quoting the path argument explicitly instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0820688. Added a
quoteShellArghelper that wraps whitespace-containing args in platform-appropriate quotes (cmd.exe double quotes on Windows, POSIX single quotes elsewhere) before handing them to the shell.runCapturednow maps every arg through it, sogrammarDirpaths underC:\Users\First Last\...won't be re-split by the shell.