Skip to content

[FSSDK-11133] Add cmab to project config #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 15, 2025
Merged

[FSSDK-11133] Add cmab to project config #399

merged 7 commits into from
Apr 15, 2025

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Apr 10, 2025

User Story

  • Update project config to track CMAB properties

Context

  • Under the Project Config Update Section of CMAB

Acceptance Criteria

  • Complete the update
  • Verify testing, add any code coverage as needed

https://jira.sso.episerver.net/browse/FSSDK-11133

@Mat001 Mat001 self-assigned this Apr 10, 2025
@Mat001 Mat001 requested review from Copilot and raju-opti April 10, 2025 17:46
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

raju-opti
raju-opti approved these changes Apr 11, 2025
View reviewed changes
Copy link

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few non-critical suggestions

@Mat001 Mat001 merged commit 0e57381 into master Apr 15, 2025
13 checks passed
@Mat001 Mat001 deleted the mpirnovar-cmab-gosdk-fssdk-11133 branch April 15, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@raju-opti raju-opti raju-opti approved these changes

Assignees

@Mat001 Mat001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mat001 @raju-opti