[FSSDK-11128] update decision service and impression event for CMAB #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raju-opti
force-pushed
the
raju/cmab_decision
branch
from
474b836 to
d966df0
Compare
raju-opti
changed the title
raju-opti
changed the title
jaeopt
requested changes
Mar 28, 2025
Comment on lines
+301
to
+317
| variation = variationId ? configObj.variationIdMap[variationId] : null; | ||
| if (!variation) { | ||
| this.logger?.debug( | ||
| USER_HAS_NO_VARIATION, | ||
| userId, | ||
| experimentKey, | ||
| ); | ||
| decideReasons.push([ | ||
| USER_HAS_NO_VARIATION, | ||
| userId, | ||
| experimentKey, | ||
| ]); | ||
| return Value.of(op, { | ||
| result: {}, | ||
| reasons: decideReasons, | ||
| }); | ||
| } |
There was a problem hiding this comment.
If this variationId-exist checking is for CMAB only, what about moving this check to CMAM decision?
| reasons: decideReasons, | ||
| }; | ||
| const cmabPromise = this.cmabService.getDecision(configObj, user, experiment.id, decideOptions).then( | ||
| (cmabDecision) => { |
There was a problem hiding this comment.
We can move the variation validate stuff above to here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues