Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10015] Fix: Explicitly define class properties #288

Merged
merged 4 commits into from
Mar 11, 2025
Merged

[FSSDK-10015] Fix: Explicitly define class properties #288

merged 4 commits into from
Mar 11, 2025

Conversation

FarhanAnjum-opti
Copy link
Contributor

Summary

  • Explicitly define class properties to get rid of deprecation warnings
  • Internal pull request of third party PR

Issues

FSSDK-10015

@coveralls
Copy link

coveralls commented Mar 11, 2025 •
edited
Loading

Coverage Status

coverage: 97.336%. remained the same
when pulling 55de1ba on benschoch/FSSDK-10015-define-class-properties
into 363cb85 on master.

@FarhanAnjum-opti FarhanAnjum-opti changed the title [FSSDK-10015] Explicitly define class properties Test Pr Mar 11, 2025
@FarhanAnjum-opti FarhanAnjum-opti changed the title Test Pr [FSSDK-10015] Fix: Explicitly define class properties Mar 11, 2025
mikechu-optimizely
mikechu-optimizely approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FarhanAnjum-opti FarhanAnjum-opti mentioned this pull request Mar 11, 2025
Closed
@FarhanAnjum-opti FarhanAnjum-opti merged commit 00eb15c into master Mar 11, 2025
17 checks passed
@FarhanAnjum-opti FarhanAnjum-opti deleted the benschoch/FSSDK-10015-define-class-properties branch March 11, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@FarhanAnjum-opti FarhanAnjum-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FarhanAnjum-opti @coveralls @mikechu-optimizely