Skip to content

[FSSDK-11362] Try 3 to fix prisma scan issue with CSRF #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

[FSSDK-11362] Try 3 to fix prisma scan issue with CSRF #452

merged 2 commits into from
May 7, 2025

Conversation

pvcraven
Copy link
Contributor

@pvcraven pvcraven commented May 2, 2025 •
edited
Loading

Summary

  • Prisma is (still) not happy with our test app because lack of CSRF protection.
  • This adds a secret key, in hopes this will make prisma happy.

Test plan

  • Merge to master, see if prisma is ok with it.
  • This is just a sample app, not much to test here.

Issues

@pvcraven pvcraven changed the title [FSSDK-11362] Try 3 to fix prisma scann issue with CSRF [FSSDK-11362] Try 3 to fix prisma scan issue with CSRF May 2, 2025
junaed-optimizely
junaed-optimizely approved these changes May 5, 2025
View reviewed changes
Copy link

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Mat001
Mat001 approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pvcraven pvcraven merged commit fd0930c into master May 7, 2025
62 of 64 checks passed
@pvcraven pvcraven deleted the pvcraven-csrf-fix-3 branch May 7, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@pvcraven pvcraven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pvcraven @Mat001 @jaeopt @junaed-optimizely