-
Notifications
You must be signed in to change notification settings - Fork 37
[FSSDK-11901] Fix concurrency bug in cmab service #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-11901] Fix concurrency bug in cmab service #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prisma Cloud has found errors in this PR ⬇️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looks ok. Glad we are removing Py and pypy 3.8. It's getting out of security updates support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
Fixes concurrency bug in cmab service by introducing locking in order to ensure consistent result.
Test plan
Introduced unit tests
Issues
FSSDK-11901