[FSSDK-11371] parsing holdout section from the datafile #577
+497
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Mar 24, 2025
Sources/Data Model/Holdout.swift
Outdated
Comment on lines
35
to
36
| var includedFlags: [String]? | ||
| var excludedFlags: [String]? |
There was a problem hiding this comment.
Make them required fields. Contents can be empty.
| var variations: [Variation] | ||
| var trafficAllocation: [TrafficAllocation] | ||
| var audienceIds: [String] | ||
| var audienceConditions: ConditionHolder? |
There was a problem hiding this comment.
audienceConditions is common between Experiment and Holdout, that's why I leave as it is.
jaeopt
requested changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues